Split equivalence code into smaller modules. #8649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb This PR is ready for a review, and would you guys take a look? |
tushushu
force-pushed
the
wip-issue-8633
branch
from
f2f22a6 to
c8be743
Compare
|
Thanks @tushushu, we will check it out and circle back with suggestions (if any) |
mustafasrepo
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Thanks @tushushu for this PR. This is very nice cleanup. LGTM!.
|
This is a pretty epic first PR @tushushu ❤️ |
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 4, 2024
* refactor * refactor * fix imports * fix ordering * private func as pub * private as pub * fix import * fix mod func * fix add_equal_conditions_test * fix project_equivalence_properties_test * fix test_ordering_satisfy * fix test_ordering_satisfy_with_equivalence2 * fix other ordering tests * fix join_equivalence_properties * fix test_expr_consists_of_constants * fix test_bridge_groups * fix test_remove_redundant_entries_eq_group * fix proj tests * test_remove_redundant_entries_oeq_class * test_schema_normalize_expr_with_equivalence * test_normalize_ordering_equivalence_classes * test_get_indices_of_matching_sort_exprs_with_order_eq * test_contains_any * test_update_ordering * test_find_longest_permutation_random * test_find_longest_permutation * test_get_meet_ordering * test_get_finer * test_normalize_sort_reqs * test_schema_normalize_sort_requirement_with_equivalence * expose func and struct * remove unused export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8633 .
Rationale for this change
What changes are included in this PR?
The
datafusion/physical-expr/src/equivalence.rshas been split into several files along with the tests.Are these changes tested?
The previous tests are still kept, and no more tests added.
Are there any user-facing changes?