Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support InterleaveExecNode in the proto #8460

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@liukun4515
Copy link
Contributor Author

@alamb @jackwener PTAL

@@ -798,3 +800,34 @@ fn roundtrip_sym_hash_join() -> Result<()> {
}
Ok(())
}

#[test]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fill the test for union and interleave

Copy link
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@liukun4515
Copy link
Contributor Author

Thanks @jackwener @metesynnada

@liukun4515 liukun4515 merged commit e2986f1 into apache:main Dec 8, 2023
22 checks passed
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liukun4515

@@ -798,3 +800,34 @@ fn roundtrip_sym_hash_join() -> Result<()> {
}
Ok(())
}

#[test]
fn roundtrip_union() -> Result<()> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants