-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support InterleaveExecNode
in the proto
#8460
Conversation
5b95fa8
to
17750d7
Compare
@alamb @jackwener PTAL |
@@ -798,3 +800,34 @@ fn roundtrip_sym_hash_join() -> Result<()> { | |||
} | |||
Ok(()) | |||
} | |||
|
|||
#[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fill the test for union and interleave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @jackwener @metesynnada |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @liukun4515
@@ -798,3 +800,34 @@ fn roundtrip_sym_hash_join() -> Result<()> { | |||
} | |||
Ok(()) | |||
} | |||
|
|||
#[test] | |||
fn roundtrip_union() -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?