Minor: refactor data_trunc to reduce duplicated code
#8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
force-pushed
the
refactor-timestamp
branch
from
965272f to
cf088f7
Compare
7 tasks
alamb
approved these changes
Dec 8, 2023
| @@ -796,6 +797,20 @@ impl ScalarValue { | |||
| ScalarValue::IntervalMonthDayNano(Some(val)) | |||
| } | |||
|
|
|||
| /// Returns a [`ScalarValue`] representing | |||
| Ok(ColumnarValue::Array(Arc::new(array))) | ||
| } | ||
|
|
||
| fn process_scalr<T: ArrowTimestampType>( |
There was a problem hiding this comment.
I believe there is a typo here:
Suggested change
| fn process_scalr<T: ArrowTimestampType>( | |
| fn process_scalar<T: ArrowTimestampType>( |
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
* refactor data_trunc * fix cast to timestamp array * fix cast to timestamp scalar * fix doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?