-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make ntile
work in some corner cases
#8371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haohuaijin we prob can also test partition by null
order by null
cases
Perhaps @mustafasrepo or @ozankabak has time to review this code as they are more familiar with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code looks good -- thank you @haohuaijin . If you can make the changes requested by @comphead I think this PR will be good to go
@comphead I find
I file an issue #8386 to track this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @haohuaijin for this PR. It is rally nice. I added a minor comment (purely stylistic, you can ignore it if you wish). This PR is LGTM!.
Co-authored-by: Mustafa Akur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @haohuaijin and @mustafasrepo
* fix: make ntile work in some corner cases * fix comments * minor * Update datafusion/sqllogictest/test_files/window.slt Co-authored-by: Mustafa Akur <[email protected]> --------- Co-authored-by: Mustafa Akur <[email protected]>
Which issue does this PR close?
Closes #8284
Rationale for this change
fix #8284
What changes are included in this PR?
Add parameter type checking using
Signature
,before
after
make
ntile
work properly, when parameter greater than table's row numberAre these changes tested?
yes, add more test
Are there any user-facing changes?