Minor: extend ci to test each package #7940
Conversation
|
FYI CI is going to fail #7939 |
.github/workflows/rust.yml
Outdated
| @@ -65,8 +65,11 @@ jobs: | |||
| # this key equals the ones on `linux-build-lib` for re-use | |||
| key: cargo-cache-benchmark-${{ hashFiles('datafusion/**/Cargo.toml', 'benchmarks/Cargo.toml', 'datafusion-cli/Cargo.toml') }} | |||
|
|
|||
| - name: Check workspace without default features | |||
| run: cargo check --no-default-features -p datafusion | |||
| - name: Check workspace without default features in each package tests | |||
There was a problem hiding this comment.
This is a really neat way of iterating over the packages
|
Draft until fix #7933 |
|
BTW there are a few other outstanding PRs that might help get the checks working -- #7934 |
|
#7933 is fixed |
Weijun-H
force-pushed
the
extend-ci
branch
2 times, most recently
from
3149b3f to
4ec8399
Compare
| - name: Check tests in each package | ||
| run: | | ||
| for package in $(cargo metadata --no-deps --format-version 1 | jq -r '.packages[].name'); do | ||
| cargo check --tests --package "$package" || exit 1 | ||
| done |
There was a problem hiding this comment.
I am not sure if we need --no-default-features to check tests 🤔
There was a problem hiding this comment.
I think this command verifies that cargo test --package "$package" will compile successfully, but it doesn't check if cargo test --no-default-features --package "$package" would run successfully
But I am not sure how common running cargo test --no-default-features --package "$package" is 🤔
|
This PR looks like it would be good to go if it got rebased against main -- is that correct @Weijun-H ? |
Yes, it is. |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Related #7933
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?