Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add doc comments to ExtractEquijoinPredicate #7658

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 26, 2023

Which issue does this PR close?

N/A

Rationale for this change

While reviewing #7612 it took me a while to find this optimziation and when I did so it was lacking in docs.

What changes are included in this PR?

Add docstrings

Screenshot 2023-09-26 at 7 37 52 AM

Are these changes tested?

N/A

Are there any user-facing changes?

Docs

@github-actions github-actions bot added the optimizer Optimizer rules label Sep 26, 2023
@viirya viirya merged commit bcc2acd into apache:main Sep 27, 2023
@viirya
Copy link
Member

viirya commented Sep 27, 2023

Thank you @alamb

@alamb alamb deleted the alamb/equijoin_predicates branch September 28, 2023 16:30
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
* Minor: add doc comments to `ExtractEquijoinPredicate`

* Update datafusion/optimizer/src/extract_equijoin_predicate.rs

Co-authored-by: Liang-Chi Hsieh <[email protected]>

---------

Co-authored-by: Liang-Chi Hsieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants