Make IN expr work with multiple items #7449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
…o fix-in-list-issue
|
LGTM 👍. |
alamb
approved these changes
Sep 6, 2023
| let list = evaluate_list(&self.list, batch)?; | ||
| make_set(list.as_ref())?.contains(value.as_ref(), self.negated)? | ||
| let value = value.into_array(batch.num_rows()); | ||
| let found = self.list.iter().map(|expr| expr.evaluate(batch)).try_fold( |
There was a problem hiding this comment.
this is a very nice formulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7448
Rationale for this change
The failure cases shown in #7448 are apparently valid. So this PR is for bug fix.
What changes are included in this PR?
The cause of the issue is that
in_exprdoesn't consider the case where the evaluated value of each expr in a list varies per row.So the issue happens in such a case except for the case
INexpr is simplified by the optimizer.The fix is to care such a case and search the target value from the list sequentially per the given RecordBatch.
Are there any user-facing changes?
Yes. But it's a bug fix.