Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serde for ShuffleWriterExec #712

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #710 .

Rationale for this change

We need this to complete the shuffle implementation.

What changes are included in this PR?

Are there any user-facing changes?

No

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me, though I don't have much experience with the ballista code.

@andygrove andygrove marked this pull request as draft July 12, 2021 23:34
@andygrove andygrove marked this pull request as ready for review July 13, 2021 00:23
@andygrove andygrove merged commit 2176ff5 into apache:master Jul 13, 2021
@andygrove andygrove deleted the serde-shuffle-writer branch July 13, 2021 00:23
@houqp houqp added the enhancement New feature or request label Jul 29, 2021
andygrove pushed a commit to andygrove/datafusion that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ballista: Implement physical plan serde for ShuffleWriterExec
3 participants