Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datafusion-cli/Dockerfile to build successfully #7031

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jul 19, 2023

Which issue does this PR close?

Closes #7030

Rationale for this change

Make the build success.

What changes are included in this PR?

To fix this issue, we need to use Rust 1.70+ and the workspace inheritance feature. So this change proposes to do so in the Dockerfile.

Are these changes tested?

Confirmed docker build and docker run works successfully.

$ docker build -f datafusion-cli/Dockerfile . --tag datafusion-cli
$ docker run -v /path/to/data/:/data -it --rm datafusion-cli:latest

Are there any user-facing changes?

No.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sarutak

@jackwener
Copy link
Member

jackwener commented Jul 20, 2023

I have a question (have nothing to do with this PR), I am curious about what specific use scenarios are this Dockerfile, I have hardly seen it being used.

I consider it because If it's useless, maybe we can remove it.

Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, verified in my local env 👍

@sarutak
Copy link
Member Author

sarutak commented Jul 20, 2023

Thank you @jackwener and @r4ntix !

I have a question (have nothing to do with this PR), I am curious about what specific use scenarios are this Dockerfile, I have hardly seen it being used.

Is it a little helpful for those who want to try to use the CLI first time?

@alamb alamb merged commit 2dd3c24 into apache:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datafusion-cli/Dockerfile doesn't work.
4 participants