Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Moving some test utils from EnsureSorting to test_utils #7009

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[MINOR] Moving some test utils from EnsureSorting to test_utils #7009

merged 1 commit into from
Jul 19, 2023

Conversation

metesynnada
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Making the test utils common.

What changes are included in this PR?

Only test utils are moved.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jul 18, 2023
mustafasrepo
mustafasrepo approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mustafasrepo mustafasrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is LGTM!. It moves some of the util functions in the sort_enforcement.rs to the test_utils.rs file.

@mustafasrepo mustafasrepo merged commit 07ffebb into apache:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafasrepo mustafasrepo mustafasrepo approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metesynnada @mustafasrepo