Support equality and comparison between interval arrays and scalars #6948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing cases for interval types to `binary_array_op_dyn_scalar`. Also added tests for the array-array and scalar-scalar cases that already work today but seem untested.
github-actions
bot
added
physical-expr
alamb
approved these changes
Jul 13, 2023
|
I have no comments to add -- the tests look very nice 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6947.
Rationale for this change
More complete support for operations between interval types.
What changes are included in this PR?
Add missing cases for interval types to
binary_array_op_dyn_scalar.Are these changes tested?
Added
.slttests. Also added tests for the array-array and scalar-scalar cases that already work today but seem untested.Are there any user-facing changes?
Yes, comparing an interval array with an interval scalar now works.