Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functions] Support Arithmetic function COT() #6925

Merged
merged 13 commits into from
Jul 14, 2023

Conversation

Syleechan
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Jul 12, 2023
@Syleechan Syleechan changed the title [EBAY-KYLIN-4185]Support Arithmetic function COT() feature:Support Arithmetic function COT() Jul 12, 2023
@@ -739,4 +779,36 @@ mod tests {
assert_eq!(ints.value(2), 75);
assert_eq!(ints.value(3), 16);
}

#[test]
fn test_cot_f32() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Syleechan Syleechan changed the title feature:Support Arithmetic function COT() [Functions] Support Arithmetic function COT() Jul 12, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the cotangent function has two arguments? Isn't it supposed to be a unary function (see here)?

There are two-argument versions of inverse trigonometric functions (e.g. atan2), but in this case you seem to be adding support for the ordinary cot function. Am I missing something?

@Syleechan
Copy link
Contributor Author

it has only one argument, and now I have use tan() instead of sin() and cos().
Yes, I just support the cot() function with one argument

@Syleechan Syleechan requested a review from ozankabak July 13, 2023 07:42
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ozankabak
Copy link
Contributor

There seems to be some build failures, we can proceed to merge if you fix them. Thanks

@liukun4515
Copy link
Contributor

There seems to be some build failures, we can proceed to merge if you fix them. Thanks

@Syleechan please fix the ci

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @Syleechan
If the ci passed, I will merge it.

@Syleechan
Copy link
Contributor Author

There seems to be some build failures, we can proceed to merge if you fix them. Thanks

CI passed,thanks

@liukun4515 liukun4515 merged commit 4d5639e into apache:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants