-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functions] Support Arithmetic function COT() #6925
Conversation
@@ -739,4 +779,36 @@ mod tests { | |||
assert_eq!(ints.value(2), 75); | |||
assert_eq!(ints.value(3), 16); | |||
} | |||
|
|||
#[test] | |||
fn test_cot_f32() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why the cotangent function has two arguments? Isn't it supposed to be a unary function (see here)?
There are two-argument versions of inverse trigonometric functions (e.g. atan2
), but in this case you seem to be adding support for the ordinary cot
function. Am I missing something?
it has only one argument, and now I have use tan() instead of sin() and cos(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There seems to be some build failures, we can proceed to merge if you fix them. Thanks |
@Syleechan please fix the ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution @Syleechan
If the ci passed, I will merge it.
CI passed,thanks |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?