Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for NestedLoopJoinExec in datafusion-proto #6902

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat: support for NestedLoopJoinExec in datafusion-proto #6902

merged 1 commit into from
Jul 11, 2023

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Jul 10, 2023

Which issue does this PR close?

Closes #6898

Rationale for this change

See #6898

What changes are included in this PR?

  • add NestedLoopJoinExecNode in datafusion.proto, then regen proto files
  • support encode/decode NestedLoopJoinExec in try_into_physical_plan and try_from_physical_plan function
  • add roundtrip_nested_loop_join unit test

Are these changes tested?

Yes

Are there any user-facing changes?

None

@github-actions github-actions bot added the core Core DataFusion crate label Jul 10, 2023
@r4ntix r4ntix marked this pull request as ready for review July 10, 2023 15:46
alamb
alamb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @r4ntix -- this looks great to me.

@Dandandan Dandandan merged commit 4e2a72f into apache:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datafusion-proto with NestedLoopJoinExec fails
3 participants
@r4ntix @Dandandan @alamb