Fix make_array null handling, update tests
#6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
commented
Jul 10, 2023
Comment on lines
+101
to
+105
| if arr.is_valid(index) { | ||
| builder.values().append_value(arr.value(index)); | ||
| } else { | ||
| builder.values().append_null(); | ||
| } |
There was a problem hiding this comment.
These lines are the only actual code change; The rest of this PR is doc comments and tests
alamb
commented
Jul 10, 2023
| (6, 11, NULL, 7.7, 'consectetur'), | ||
| (7, 13, 14, NULL, 'adipiscing'), | ||
| (8, 15, 16, 8.8, NULL) | ||
| (1, 1, 2, 1.1, 'Lorem', 'A'), |
There was a problem hiding this comment.
adds a new column, e and whitespace OCD
alamb
commented
Jul 10, 2023
| # make_array with columns #2 | ||
| # make_array with 1 columns | ||
| query ??? | ||
| select make_array(a), make_array(d), make_array(e) from values; |
There was a problem hiding this comment.
I broke out the tests for make_array with a single column from the tests of make_array with 2 column
|
cc @izveigor |
izveigor
reviewed
Jul 10, 2023
izveigor
reviewed
Jul 10, 2023
| /// │ │ [C, Z] │ │ │ │ NULL │ │ │ │ [C, Z, NULL] │ │ | ||
| /// │ └──────────┘ │ │ └──────────┘ │ │ └────────────────────┘ │ | ||
| /// └──────────────┘ └──────────────┘ └────────────────────────┘ | ||
| /// col1 col2 output |
There was a problem hiding this comment.
There are good comments 👍
I think we can make a custom template for all array functions.
izveigor
reviewed
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6887
Rationale for this change
Fix a bug (see #6887)
What changes are included in this PR?
NOTE this PR looks large, but has only 4 lines of code changes. The rest of it is doc comments and tests
nullwhen creating new arraysAre these changes tested?
yes
Are there any user-facing changes?
fix regression