Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on main due to logical conflict #6875

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 7, 2023

Which issue does this PR close?

N/A

Rationale for this change

#6860 and #6835 conflicted logically and cause compilation to fail on main:

https://github.com/apache/arrow-datafusion/actions/runs/5483558927/jobs/9990031096

Compiling datafusion v27.0.0 (D:\a\arrow-datafusion\arrow-datafusion\datafusion\core)
error[E0252]: the name `DisplayFormatType` is defined multiple times
  --> datafusion\core\src\physical_plan\streaming.rs:38:24
   |
34 |     DisplayFormatType, ExecutionPlan, Partitioning, SendableRecordBatchStream,
   |     ----------------- previous import of the type `DisplayFormatType` here
...
38 | use super::{DisplayAs, DisplayFormatType};
   |                        ^^^^^^^^^^^^^^^^^ `DisplayFormatType` reimported here
   |
   = note: `DisplayFormatType` must be defined only once in the type namespace of this module

error[E0407]: method `fmt_as` is not a member of trait `ExecutionPlan`
   --> datafusion\core\src\physical_plan\streaming.rs:167:5
    |
167 | /     fn fmt_as(
168 | |         &self,
169 | |         t: DisplayFormatType,
170 | |         f: &mut std::fmt::Formatter,
...   |
203 | |         }
204 | |     }
    | |_____^ not a member of trait `ExecutionPlan`

warning: unused import: `DisplayFormatType`
  --> datafusion\core\src\physical_plan\streaming.rs:38:24
   |
38 | use super::{DisplayAs, DisplayFormatType};
   |                        ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

What changes are included in this PR?

Fix conflict

Are these changes tested?

yes, by CI

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review July 7, 2023 08:09
@github-actions github-actions bot added the core Core DataFusion crate label Jul 7, 2023
@alamb
Copy link
Contributor Author

alamb commented Jul 7, 2023

I am going to merge this in prior to review to get main building again. I am happy to make changes as a follow on PR

@alamb alamb merged commit 6aeea6b into apache:main Jul 7, 2023
@alamb alamb deleted the alamb/fix_build_3 branch July 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant