Support array concatenation for arrays with different dimensions #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
physical-expr
|
@izveigor do you have time to review this PR, perhaps? |
izveigor
reviewed
Jul 7, 2023
| @@ -365,6 +365,31 @@ select array_concat(make_array(), make_array(2, 3)); | |||
| ---- | |||
| [2, 3] | |||
|
|
|||
| # array_concat with different dimensions | |||
There was a problem hiding this comment.
In my opinion, it would be better to write # array_concat with different dimensions #1 (2D + 1D) in all test cases (where 1 is the test case number).
izveigor
reviewed
Jul 7, 2023
| select array_concat(make_array(10, 20), make_array([30, 40]), make_array([[50, 60]])) | ||
| ---- | ||
| [[[10, 20]], [[30, 40]], [[50, 60]]] | ||
|
|
There was a problem hiding this comment.
We also have test cases with the concatenation operator.
Could you please write some test cases with it?
There was a problem hiding this comment.
This PR fails on the concatenation operator. I will request another PR on this.
izveigor
reviewed
Jul 7, 2023
|
|
||
| fn align_array_dimensions(args: Vec<ArrayRef>) -> Result<Vec<ArrayRef>> { | ||
| // Compute the number of dimensions for each array | ||
| let args_ndim: Result<Vec<u8>> = args |
There was a problem hiding this comment.
let args_ndim = args.iter().map(|arr| compute_array_ndims(0, arr.clone).max()?;
izveigor
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Thank you, @jayzhan211!
I left a few minor nitpicks. But I think that the code does not contain serious errors.
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
force-pushed
the
diff1_arryconcat
branch
from
ab4f6a8 to
88bca14
Compare
alamb
changed the title
alamb
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #6849
Rationale for this change
What changes are included in this PR?
Calculate dims for each array in concat(), find the max one, and wrap each array to the same dims.
Note that this change does not restrict that each array dimension should be diff by 1 as mentioned in the issue, but I think it is fine not to restrict that, If we need to ensure that, we just need additional error handling.
Are these changes tested?
Are there any user-facing changes?