feat: column support for array_dims, array_ndims, cardinality and array_length
#6864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
11 tasks
|
Thanks @izveigor -- I plan to review this over the weekend (also I found #6887 which is related perhaps). I can't keep up with all the structured array goodness you and @jayzhan211 are throwing our way! |
|
🤔 maybe you and @jayzhan211 could potentially review each other's PRs initially? |
alamb
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Thanks @izveigor -- I took a look through this PR and while I don't understand the entire thing I think it is a step forward and we should merge it in.
I think this PR has a conflict but once that is resolved I'll plan to merge
|
Thank you @jayzhan211 for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6804
Closes #6693
Rationale for this change
This is the second PR for solving the column issue.
What changes are included in this PR?
Four array functions now start to support column data:
array_dims,array_ndims,cardinality,array_lengthAre these changes tested?
Yes
Are there any user-facing changes?
Yes