test: parquet use the byte array as the physical type to store decimal #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL. @liukun4515 :-) |
|
Could you help me review this, @alamb I'm not sure we need this test. |
alamb
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
Thanks @smallzhongfeng -- I think this looks reasonable to me and is an improvement and the tests now document the current behavior. If we need to update the behavior at least it will be covered.
Thanks for the ping and sorry for the delay
|
Thanks for you reivew! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #2960
Rationale for this change
Add one more test.
What changes are included in this PR?
Add a test for parquet use the byte array as the physical type to store decimal.
Are these changes tested?
Are there any user-facing changes?
No.