Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IsUnkown and IsNotUnkown expression #6830

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Simplify IsUnkown and IsNotUnkown expression #6830

merged 1 commit into from
Jul 3, 2023

Conversation

jonahgao
Copy link
Member

@jonahgao jonahgao commented Jul 3, 2023

Which issue does this PR close?

Related to #6345

Rationale for this change

Quoted from the PostgreSQL documentation:

Notice that IS UNKNOWN and IS NOT UNKNOWN are effectively the same as IS NULL and IS NOT NULL, respectively, except that the input expression must be of Boolean type.

So they can apply the same simplification rules.

What changes are included in this PR?

Simplify IsUnkown and IsNotUnkown expression

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the optimizer Optimizer rules label Jul 3, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @jonahgao

@alamb alamb merged commit bee2265 into apache:main Jul 3, 2023
@jonahgao jonahgao deleted the simplify_unknown branch July 4, 2023 02:02
2010YOUY01 pushed a commit to 2010YOUY01/arrow-datafusion that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants