feat: add -c option to pass the SQL query directly as an argument on datafusion-cli
#6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
considering the increasing feature richness of the cli, I added integration tests.
Thank you @r4ntix !
I also tested this locally and it works great ❤️
/Users/alamb/Software/target-df/debug/datafusion-cli -c 'show tables';
DataFusion CLI v26.0.0
+---------------+--------------------+-------------+------------+
| table_catalog | table_schema | table_name | table_type |
+---------------+--------------------+-------------+------------+
| datafusion | information_schema | tables | VIEW |
| datafusion | information_schema | views | VIEW |
| datafusion | information_schema | columns | VIEW |
| datafusion | information_schema | df_settings | VIEW |
+---------------+--------------------+-------------+------------+
4 rows in set. Query took 0.005 seconds.|
|
||
| #[rstest] | ||
| #[case::exec_from_commands( | ||
| ["--command", "select 1", "--format", "json", "-q"], |
|
I also doubled checked the new tests are run as part of CI: https://github.com/apache/arrow-datafusion/actions/runs/5378911179/jobs/9759609935?pr=6765
THanks again @r4ntix -- this PR is really neat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6763
Rationale for this change
See #6763
What changes are included in this PR?
-c optionto pass the SQL query directly as an argument on datafusion-cliAre these changes tested?
Are there any user-facing changes?
Add
-c optionon datafusion-cli