Minor: consolidate datafusion_substrait tests into substrait_integration to save builder space and build time #6685
#6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 15, 2023
| @@ -0,0 +1,697 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
I moved these files and then removed a level of indenting as
#[cfg(test)]
mod tests {is not necessary for integration tests
. I did not change any of the tests
waynexia
approved these changes
Jun 16, 2023
crepererum
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6676
Rationale for this change
This is the same pattern applied in #6682
Basically, each test binary has about 125MB of overhead (the size of the datafusion code that is linked in). Thus I estimate this PR to save 2 * ~125 MB of builder space as it reduces the number of test binaries created by 2
What changes are included in this PR?
consolidate repartition test into
substrait_integrationto save builder space and build timeAre these changes tested?
Yes
Are there any user-facing changes?
no