Remove temporal to kernels_arrow #6069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb I hope it was in line with your plan to move the codes. If there are places you think would be better, I'd love to hear. |
alamb
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Thank you @berkaysynnada -- this is definitely in the right direction.
Eventually my hope is to use the add_dyn kernels directly. This feature was added in apache/arrow-rs#4038 by @Weijun-H which will be in arrow 38 which should be landing in DataFusion sometime next week
|
@berkaysynnada can you please resolve the conflicts with this PR? I don't really understand the issue, but I suspect it will be straightforward to fix |
viirya
reviewed
Apr 23, 2023
Co-authored-by: Liang-Chi Hsieh <[email protected]>
berkaysynnada
deleted the
feature/removal-temporal-arith-to-kernels-arrow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5704.
Rationale for this change
Temporal arithmetic code will be moved to arrow-rs eventually. For this purpose, this PR is an intermediate step that facilitates the process (the same pattern used for other removals).
What changes are included in this PR?
In datetime.rs, the
evaluate()function calls the binary.rs functionresolve_temporal_op()andresolve_temporal_op_scalar(), according to type of the second value, Array or Scalar. It can access the add/sub_dyn...() functions in kernels_arrow.rs (the functions that will be moved to arrow-rs deployed here until arrow-rs changes happen)Are these changes tested?
Yes, with existing tests.
Are there any user-facing changes?