Add primary key information to CreateMemoryTable LogicalPlan node #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
avantgardnerio
changed the title
avantgardnerio
commented
Apr 3, 2023
avantgardnerio
commented
Apr 3, 2023
avantgardnerio
commented
Apr 3, 2023
avantgardnerio
commented
Apr 3, 2023
yjshen
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Thanks @avantgardnerio! Looks good overall, I left some minor comments.
Also, I find it easier to review without whitespace: https://github.com/apache/arrow-datafusion/pull/5835/files?diff=split&w=1
alamb
reviewed
Apr 3, 2023
added 2 commits
April 3, 2023 07:53
added 2 commits
April 3, 2023 08:50
|
Okay fellas, I think this is ready... |
avantgardnerio
commented
Apr 3, 2023
| fn plan_create_table_with_pk() { | ||
| let sql = "create table person (id int, name string, primary key(id))"; | ||
| let plan = r#" | ||
| CreateMemoryTable: Bare { table: "person" } primary_key=[id] |
There was a problem hiding this comment.
Should show PK
avantgardnerio
commented
Apr 3, 2023
| fn plan_create_table_no_pk() { | ||
| let sql = "create table person (id int, name string)"; | ||
| let plan = r#" | ||
| CreateMemoryTable: Bare { table: "person" } |
There was a problem hiding this comment.
Does not change existing behavior if no PK
avantgardnerio
commented
Apr 3, 2023
| } | ||
|
|
||
| #[test] | ||
| #[should_panic(expected = "Non-primary unique constraints are not supported")] |
There was a problem hiding this comment.
Unhanded syntax causes errors.
yjshen
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5834.
Rationale for this change
As a developer building a database atop DataFusion, it would be useful to have knowledge of primary keys retained in the LogicalPlan.
What changes are included in this PR?
A new
primary_keyfield onLogicalPlan::CreateMemoryTableAre these changes tested?
Sort of - there's a test that broke before, but I couldn't figure out what prints this LogicalPlan node, so I wasn't able to add the pk info to the
Debugtrait and assert that.Are there any user-facing changes?
create tablestatements that used to fail (e.g. withprimary keyclauses) will now not fail. I'm not sure if that's an issue for anyone.