minor: reduce replication in date_bin implementation
#5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #5643 and #5641
Rationale for this change
I saw a way to reduce some code duplication introduced in #5643 but felt it would not be fair to @Weijun-H to go back and forth more on that PR because #5643 implemented the desired behavior, and this is just a code cleanup
What changes are included in this PR?
refactor the
date_binimplementation to have a single implementation for 2 and 3 argument formsAre these changes tested?
Existing coverage
Are there any user-facing changes?
No