Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: added tests and fixed comments in "math_expressions" #5656

Merged
merged 2 commits into from
Mar 21, 2023
Merged

refactoring: added tests and fixed comments in "math_expressions" #5656

merged 2 commits into from
Mar 21, 2023

Conversation

izveigor
Copy link
Contributor

Rationale for this change

Added tests.
Fixed some comments of functions.

What changes are included in this PR?

Refactoring

Are these changes tested?

Yes

Are there any user-facing changes?

Yes (commenting)

@github-actions github-actions bot added the physical-expr Physical Expressions label Mar 20, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @izveigor

@alamb alamb merged commit 695db00 into apache:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants