-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return schema of ExtensionPlan instead of its children's #5514
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Make great sense to me, thanks @waynexia . Can you add a test to cover this case? thanks again. |
Signed-off-by: Ruihang Xia <[email protected]>
Appreciate your suggestion! I add a UT for this change, but only covers the |
I think we can add an extra integration-test to cover this case, look like unit test isn't enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is an improvement and has test coverage. I agree with @jackwener we can probably improve the coverage but I also think we can do so in a follow on PR
Thanks @waynexia |
Benchmark runs are scheduled for baseline = 55c7c4d and contender = 6a8c4a6. 6a8c4a6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Related to #5513, but not close it as there is another unfinished discussion.
Rationale for this change
#5236 returns chindren's schema rather than
ExtensionPlan
's inall_schema
, which will break other places that make use ofExtensionPlan
.What changes are included in this PR?
Correct
all_schema
's behaviorAre these changes tested?
Are there any user-facing changes?