Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate timezone to created arrays #5481

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Propagate timezone to created arrays #5481

merged 2 commits into from
Mar 6, 2023

Conversation

maxburke
Copy link
Contributor

@maxburke maxburke commented Mar 4, 2023

This fixes #5480

@maxburke maxburke mentioned this pull request Mar 4, 2023
Closed
alamb
alamb reviewed Mar 5, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxburke -- can you please add some tests as well (so we don't accidentally break this functionality in the future)?

@maxburke
Add test for timezone propogation
acad8e5 
This was manifesting as an error in the use of window functions on
Timestamp types with Arrow failing to concatenate arrays of different
data types (one array with a timezone, one without).
@github-actions github-actions bot added the core Core DataFusion crate label Mar 5, 2023
@maxburke
Copy link
Contributor Author

maxburke commented Mar 5, 2023

@alamb Done!

alamb
alamb approved these changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxburke !

datafusion/core/tests/sql/parquet.rs
);
}

assert_eq!(131072, num_rows);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

In the future you could also use sqllogictest to write this kind of test. Something like https://github.com/apache/arrow-datafusion/blob/eb9541380964a5fd5aa92302a82ec189c3be792e/datafusion/core/tests/sqllogictests/test_files/window.slt#L18-L36

@alamb alamb merged commit 21e33a3 into apache:main Mar 6, 2023
@alamb
Copy link
Contributor

alamb commented Mar 6, 2023

Thanks again @maxburke

@ursabot
Copy link

ursabot commented Mar 6, 2023

Benchmark runs are scheduled for baseline = 978ec2d and contender = 21e33a3. 21e33a3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@korowa korowa mentioned this pull request Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScalarValue::iter_to_array does not add propogate timezone
3 participants
@maxburke @alamb @ursabot