Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make GeometricMean not to have update and merge #5469

Merged
merged 1 commit into from
Mar 6, 2023
Merged

refactor: make GeometricMean not to have update and merge #5469

merged 1 commit into from
Mar 6, 2023

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Mar 3, 2023

Which issue does this PR close?

Parts #1598

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@Weijun-H Weijun-H force-pushed the refactor-GeometricMean branch from a8124a4 to 59341fe Compare March 3, 2023 17:46
@Weijun-H Weijun-H changed the title refactor: make GeometricMean not to have update and merge refactor: make GeometricMean not to have update and merge Mar 3, 2023
@Weijun-H Weijun-H changed the title refactor: make GeometricMean not to have update and merge refactor: make GeometricMean not to have update and merge Mar 3, 2023
@Weijun-H Weijun-H force-pushed the refactor-GeometricMean branch from 59341fe to b2a3a32 Compare March 3, 2023 18:09
alamb
alamb approved these changes Mar 4, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup -- thank you @Weijun-H

waynexia
waynexia approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 978ec2d into apache:main Mar 6, 2023
@ursabot
Copy link

ursabot commented Mar 6, 2023

Benchmark runs are scheduled for baseline = c56b947 and contender = 978ec2d. 978ec2d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Weijun-H @ursabot @alamb @waynexia