Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: express unsigned literal in substrait #5448

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Mar 2, 2023

Which issue does this PR close?

Closes #5169.

Rationale for this change

Unsigned types are part of DataFusion/Arrow's type system. This patch adds support for UInt8, UInt16, UInt32 and UInt64 types.

What changes are included in this PR?

Support for unsigned literal types using type variation reference. 1 stands for unsigned and 0 stands for signed.

As my investigation, DuckDB doesn't support unsigned types https://github.com/duckdblabs/substrait/blob/main/src/from_substrait.cpp#L84-L101

Are these changes tested?

add one UInt32 column to the test data. And a new round-trip SQL case.

Are there any user-facing changes?

@waynexia
Copy link
Member Author

waynexia commented Mar 2, 2023

cc @andygrove @nseekhao please take a look ❤️

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @waynexia

@alamb alamb merged commit c37ddf7 into apache:main Mar 4, 2023
@ursabot
Copy link

ursabot commented Mar 4, 2023

Benchmark runs are scheduled for baseline = 53a638e and contender = c37ddf7. c37ddf7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@waynexia waynexia deleted the unsigned-literal branch March 6, 2023 02:38
@andygrove andygrove added the enhancement New feature or request label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request substrait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substrait: Add support for unsigned primitive and literal
4 participants