feat: express unsigned literal in substrait #5448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5169.
Rationale for this change
Unsigned types are part of DataFusion/Arrow's type system. This patch adds support for
UInt8
,UInt16
,UInt32
andUInt64
types.What changes are included in this PR?
Support for unsigned literal types using type variation reference.
1
stands for unsigned and0
stands for signed.As my investigation, DuckDB doesn't support unsigned types https://github.com/duckdblabs/substrait/blob/main/src/from_substrait.cpp#L84-L101
Are these changes tested?
add one UInt32 column to the test data. And a new round-trip SQL case.
Are there any user-facing changes?