Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: add forgotten large_utf8 #5393

Merged
merged 1 commit into from
Feb 25, 2023
Merged

minor: add forgotten large_utf8 #5393

merged 1 commit into from
Feb 25, 2023

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Feb 25, 2023 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

#5384 (comment) from @waynexia

we also should support DataType::LargeUtf8 in #5234.

What changes are included in this PR?

add forgotten large_utf8

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Feb 25, 2023
@jackwener jackwener force-pushed the minor branch 2 times, most recently from 461c58c to 659e6b7 Compare February 25, 2023 06:53
waynexia
waynexia approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job😄

@jackwener jackwener merged commit 645428f into apache:main Feb 25, 2023
@jackwener jackwener deleted the minor branch February 25, 2023 15:14
@ursabot
Copy link

ursabot commented Feb 25, 2023

Benchmark runs are scheduled for baseline = 248d6fc and contender = 645428f. 645428f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjshen yjshen yjshen approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackwener @ursabot @yjshen @waynexia