Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ExecutionPlan::relies_input_order (has been replaced with required_input_ordering) #4856

Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 8, 2023

Which issue does this PR close?

Related to #4686

Rationale for this change

#4691 from @mustafasrepo made the relies_on_input redundant in favor of the more general required_input_ordering

What changes are included in this PR?

Remove relies_on_input

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No, though it is an API change

@alamb alamb added the api change Changes the API exposed to users of the crate label Jan 8, 2023
@github-actions github-actions bot added the core Core DataFusion crate label Jan 8, 2023
@ozankabak
Copy link
Contributor

LGTM -- commits that only remove stuff are the best commits 🤣

@mingmwang
Copy link
Contributor

LGTM. I remember originally there is logic insider the Repartition rule to check the relies_on_input_order(), it seems this logic was removed recently.

@alamb
Copy link
Contributor Author

alamb commented Jan 9, 2023

LGTM. I remember originally there is logic insider the Repartition rule to check the relies_on_input_order(), it seems this logic was removed recently.

Yes I believe it was removed in https://github.com/apache/arrow-datafusion/pull/4714/files#diff-4f2e98e6466bc2e0f66c0fdb844f46ef25c6b5b559f9c51610dd9273da2b2ec1L859 from @yahoNanJing

@yahoNanJing
Copy link
Contributor

LGTM

@tustvold tustvold merged commit 39d98f8 into apache:master Jan 11, 2023
@ursabot
Copy link

ursabot commented Jan 11, 2023

Benchmark runs are scheduled for baseline = 98b4696 and contender = 39d98f8. 39d98f8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/remove_unecessary_relies_on_input_order branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants