Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle trailing tbl column in TPCH benchmarks #4821

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 4, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

The tbl format is of the form

a|b|c|

Note the trailing |. Interpreting this as CSV therefore adds an additional trailing column, currently the CSV reader just ignores this. However, with arrow 30 the reader now complains if you give it a schema that doesn't match the file. The changes in this PR work around this

What changes are included in this PR?

Adds an additional __placeholder column to the schema when reading from a tbl file, this can then be projected out. This was a quick way to workaround this issue without polluting the general codebase with support for what appears to be a TPCH specific data format?

Are these changes tested?

Are there any user-facing changes?

@tustvold tustvold force-pushed the handle-tbl-trailing-column branch from 0247e39 to cb0588a Compare January 4, 2023 18:16
@tustvold tustvold force-pushed the handle-tbl-trailing-column branch from cb0588a to 7124770 Compare January 4, 2023 18:58
@tustvold tustvold mentioned this pull request Jan 4, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you @tustvold

@alamb alamb merged commit b410fce into apache:master Jan 5, 2023
@ursabot
Copy link

ursabot commented Jan 5, 2023

Benchmark runs are scheduled for baseline = 702e117 and contender = b410fce. b410fce is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants