Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all equality predicates in equality join #4193

Merged
merged 12 commits into from
Nov 17, 2022
Merged

Support all equality predicates in equality join #4193

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4352bb2
Support normal expressions in equality join
ygf11 Nov 11, 2022
60629ac
Add some tests
ygf11 Nov 14, 2022
0156249
Improve comment
ygf11 Nov 14, 2022
003ff98
Update datafusion/sql/src/planner.rs
ygf11 Nov 16, 2022
0f7547e
Add another test case
ygf11 Nov 16, 2022
3a04cbd
Add comment
ygf11 Nov 16, 2022
5786cc8
Merge upstream/master branch into ygf11/expr-eq-join
ygf11 Nov 16, 2022
f605adf
fix typo
ygf11 Nov 16, 2022
1a9a672
remove dumplicated keys in projection and add test cases
ygf11 Nov 17, 2022
e8f6580
Merge upstream/master branch to ygf11/expr-eq-join
ygf11 Nov 17, 2022
b5ec653
fix comment
ygf11 Nov 17, 2022
15188e8
fix typo
ygf11 Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions datafusion/expr/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,18 @@ pub fn can_hash(data_type: &DataType) -> bool {
}
}

/// Check whether all columns are from the schema.
pub fn check_all_column_from_schema(
columns: &HashSet<Column>,
schema: DFSchemaRef,
) -> Result<bool> {
let result = columns
.iter()
.all(|column| schema.index_of_column(column).is_ok());

Ok(result)
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
Loading