Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Use Operator::swap #4092

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 2, 2022

Which issue does this PR close?

N/A

Rationale for this change

While reviewing #3912 from @isidentical I noticed there was some duplication of "reverse the operator" logic in DataFusion

Less duplication I think leads to easier to understand code

What changes are included in this PR?

Use Operator::swap() in pruning predicate rather than another copy

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review November 2, 2022 19:57
@github-actions github-actions bot added the core Core DataFusion crate label Nov 2, 2022
@isidentical
Copy link
Contributor

I didn't notice something similar was already in the codebase when adding the swap(), thanks for catching it! Looks great ☑️

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge!

@xudong963 xudong963 merged commit 8741372 into apache:master Nov 3, 2022
@ursabot
Copy link

ursabot commented Nov 3, 2022

Benchmark runs are scheduled for baseline = 52930cd and contender = 8741372. 8741372 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
* minor: Use Operator::swap

* fixup
@alamb alamb deleted the alamb/less_duplication branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants