Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Print unoptimized logical plan in execute_query of tpch benchmark #4056

Merged
merged 1 commit into from
Nov 1, 2022
Merged

MINOR: Print unoptimized logical plan in execute_query of tpch benchmark #4056

merged 1 commit into from
Nov 1, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 1, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Based on the context, the first print-out query plan should be unoptimized logical plan.

What changes are included in this PR?

Are there any user-facing changes?

viirya
viirya commented Nov 1, 2022
View reviewed changes
benchmarks/src/bin/tpch.rs
@@ -290,7 +290,7 @@ async fn execute_query(
debug: bool,
) -> Result<Vec<RecordBatch>> {
let plan = ctx.sql(sql).await?;
let plan = plan.to_logical_plan()?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is optimized plan actually which duplicates later.

@viirya viirya force-pushed the minor_fix_query_plan branch from 37d98d0 to e5049fe Compare November 1, 2022 08:13
@alamb alamb changed the title MINOR: Print unoptimized logical plan in execute_query MINOR: Print unoptimized logical plan in execute_query of tpch benchmark query Nov 1, 2022
@alamb alamb changed the title MINOR: Print unoptimized logical plan in execute_query of tpch benchmark query MINOR: Print unoptimized logical plan in execute_query of tpch benchmark Nov 1, 2022
@andygrove andygrove merged commit 2b08a43 into apache:master Nov 1, 2022
@ursabot
Copy link

ursabot commented Nov 1, 2022

Benchmark runs are scheduled for baseline = 41467ab and contender = 2b08a43. 2b08a43 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@viirya @Dandandan
Use unoptimized logical plan (apache#4056)
a4bb71a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viirya @ursabot @alamb @andygrove