-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert async changes but keep deltalake working #3978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it works for delta-rs it works for me. Thanks @avantgardnerio
Thanks @avantgardnerio. LGTM |
Benchmark runs are scheduled for baseline = 00d23a2 and contender = fa5cd7f. fa5cd7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3977.
Rationale for this change
Described in the issue.
What changes are included in this PR?
with_schema
method toTableProviderFactory
for non-async useAre there any user-facing changes?
They will have to find a non-async way to create their tables.