Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert async changes but keep deltalake working #3978

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #3977.

Rationale for this change

Described in the issue.

What changes are included in this PR?

  1. Revert the async change
  2. (re)add the with_schema method to TableProviderFactory for non-async use

Are there any user-facing changes?

They will have to find a non-async way to create their tables.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works for delta-rs it works for me. Thanks @avantgardnerio

@github-actions github-actions bot removed the core Core DataFusion crate label Oct 26, 2022
@avantgardnerio avantgardnerio marked this pull request as ready for review October 26, 2022 22:57
@yahoNanJing
Copy link
Contributor

Thanks @avantgardnerio. LGTM

@andygrove andygrove merged commit fa5cd7f into apache:master Oct 27, 2022
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = 00d23a2 and contender = fa5cd7f. fa5cd7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@avantgardnerio avantgardnerio deleted the bg_revert_async branch October 27, 2022 15:28
Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async deserialization functions are unintuitive and possibly insecure
5 participants