Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#352: BallistaContext::collect() logging is too noisy #394

Merged
merged 7 commits into from
May 27, 2021
Merged

#352: BallistaContext::collect() logging is too noisy #394

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9bf5dc
#352: BallistaContext::collect() logging is too noisy, change info me…
jgoday May 23, 2021
b1642be
#352: BallistaContext::collect() logging is too noisy, change info me…
jgoday May 23, 2021
2abaa34
Merge branch 'ballista_context_collect_info' of github.com:jgoday/arr…
jgoday May 23, 2021
d192291
BallistaContext::collect info or trace a job as queued/running if fir…
jgoday May 23, 2021
f270075
BallistaContext::collect loop info message when status changed
jgoday May 26, 2021
9f7c6fd
BallistaContext::collect Remove unnecessary macro for trace/info
jgoday May 26, 2021
8dbc2c7
BallistaContext::collect Fix has_status_change default value (true)
jgoday May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ballista/rust/client/src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ impl BallistaContext {
.into_inner()
.job_id;

let mut prev_status: Option<job_status::Status> = None;

loop {
let GetJobStatusResult { status } = scheduler
.get_job_status(GetJobStatusParams {
Expand All @@ -198,14 +200,21 @@ impl BallistaContext {
DataFusionError::Internal("Received empty status message".to_owned())
})?;
let wait_future = tokio::time::sleep(Duration::from_millis(100));
let has_status_change = prev_status.map(|x| x != status).unwrap_or(true);
match status {
job_status::Status::Queued(_) => {
info!("Job {} still queued...", job_id);
if has_status_change {
info!("Job {} still queued...", job_id);
}
wait_future.await;
prev_status = Some(status);
}
job_status::Status::Running(_) => {
info!("Job {} is running...", job_id);
if has_status_change {
info!("Job {} is running...", job_id);
}
wait_future.await;
prev_status = Some(status);
}
job_status::Status::Failed(err) => {
let msg = format!("Job {} failed: {}", job_id, err.error);
Expand Down