Support filter/limit pushdown for views/dataframes #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
changed the title
Support filter, limit pushdown for views/dataframes Support filter, limit pushdown for views/dataframes Support filter, limit pushdown for views/dataframes
Dandandan
force-pushed
the
filter_pushdown_views_dataframes
branch
from
f74373e to
deda756
Compare
alamb
approved these changes
Oct 20, 2022
| &self, | ||
| _filter: &Expr, | ||
| ) -> Result<TableProviderFilterPushDown> { | ||
| // A filter is added on the DataFrame when given |
| .select_columns(&["bool_col", "int_col"])?; | ||
|
|
||
| let plan = df.explain(false, false)?.collect().await?; | ||
| // Filters all the way to Parquet |
| self.logical_plan().clone() | ||
| }; | ||
| let mut plan = LogicalPlanBuilder::from(plan); | ||
| let filter = filters.iter().cloned().reduce(|acc, new| acc.and(new)); |
There was a problem hiding this comment.
You could use conjunction here and above too if you wanted : https://github.com/apache/arrow-datafusion/blob/master/datafusion/optimizer/src/utils.rs#L123-L147
it just does the same thing, so I don't feel strongly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3681
Closes #3249
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?