Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precision != 0 check when making decimal type #3818

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented Oct 13, 2022

Which issue does this PR close?

Closes #3665.

Rationale for this change

The precision of decimal type should not be zero, which we should check it.

What changes are included in this PR?

  1. Add precision != 0 check
  2. Update the error message to make it more readable
  3. Add tests.

Are there any user-facing changes?

@github-actions github-actions bot added the sql SQL Planner label Oct 13, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaoYang670

Can you please file a ticket in arrow-rs if you think it should be fixed there as well?

@alamb alamb merged commit 051f243 into apache:master Oct 13, 2022
@ursabot
Copy link

ursabot commented Oct 13, 2022

Benchmark runs are scheduled for baseline = c989b8e and contender = 051f243. 051f243 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HaoYang670
Copy link
Contributor Author

Thank you for review @alamb .

Can you please file a ticket in arrow-rs if you think it should be fixed there as well?

I've filed apache/arrow-rs#2852 to discuss a better way to solve this problem.

@HaoYang670 HaoYang670 deleted the 3665_decimal_precision_0 branch October 13, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using Decimal(0) make system panicked
3 participants