unwrap_cast_in_comparison: fix bug which can find the field for the schema
#3699
Conversation
|
We can close this pr: #3694 cc @andygrove @alamb I migrate some test in #3694 to this pr, thanks @andygrove |
| fn case_when() -> Result<()> { | ||
| let sql = "SELECT CASE WHEN col_int32 > 0 THEN 1 ELSE 0 END FROM test"; | ||
| let plan = test_sql(sql)?; | ||
| let expected = "Projection: CASE WHEN #test.col_int32 > Int32(0) THEN Int64(1) ELSE Int64(0) END\ |
There was a problem hiding this comment.
This plan doesn't look ideal to me -- since col_int32 is int32 I think the exprs could be rewritten to
CASE WHEN #test.col_int32 > Int32(0) THEN Int32(1) ELSE Int32(0) END
Could be done as a follow on PR for sure
There was a problem hiding this comment.
@alamb yes,
we can support the unsigned numeric data type in the UnwrapCastInBinaryComparison rule
|
Benchmark runs are scheduled for baseline = d0760f3 and contender = 5731228. 5731228 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3690
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?