-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for querying S3 data with CLI #3631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this!
/// - AWS_SECRET_ACCESS_KEY | ||
/// | ||
#[tokio::main] | ||
async fn main() -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example currently fails with:
Error: ObjectStore(Generic { store: "S3", source: MissingLastModified })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed #3633 for this
Codecov Report
@@ Coverage Diff @@
## master #3631 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 300 300
Lines 56416 56469 +53
=======================================
+ Hits 48525 48576 +51
- Misses 7891 7893 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
datafusion-cli/README.md
Outdated
|
||
The CLI can query data in S3 if the following environment variables are defined: | ||
|
||
- `AWS_DEFAULT_REGION` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWS_REGION is more standard, AWS_DEFAULT_REGION is the fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove
$ export AWS_SECRET_ACCESS_KEY=*************************** | ||
$ export AWS_ACCESS_KEY_ID=************** | ||
|
||
$ ./target/release/datafusion-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so cool
Benchmark runs are scheduled for baseline = b4c0601 and contender = 06a4f79. 06a4f79 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3399
Rationale for this change
We should tell users how to use these new features
What changes are included in this PR?
Docs
Are there any user-facing changes?
No