Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop wasting time in CI on MIRI runs #3610

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 25, 2022

Which issue does this PR close?

re #3045

Rationale for this change

DataFusion runs a check called "MIRI" as part of CI. Example: https://github.com/apache/arrow-datafusion/actions/runs/3119021327/jobs/5058711471

This check always completes successfully as the results of running miri are || true d (aka ignored)

This provides a false sense of security (we run MIRI!) as well as wasting CI resources

What changes are included in this PR?

Stop running MIRI check in CI

Are there any user-facing changes?

No

Follow on ticket to create a working MIRI CI check: #3611

@alamb alamb added the development-process Related to development process of DataFusion label Sep 25, 2022
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Sep 25, 2022
@alamb alamb added the development-process Related to development process of DataFusion label Sep 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3610 (00e3ac6) into master (ebb28f5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3610   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files         300      300           
  Lines       56314    56314           
=======================================
+ Hits        48473    48475    +2     
+ Misses       7841     7839    -2     
Impacted Files Coverage Δ
datafusion/expr/src/logical_plan/plan.rs 77.26% <0.00%> (+0.16%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.56% <0.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 @alamb i will update in ballista apache/datafusion-ballista#283 (comment)

@alamb alamb merged commit ced3b27 into apache:master Sep 26, 2022
@ursabot
Copy link

ursabot commented Sep 26, 2022

Benchmark runs are scheduled for baseline = c8a9ea0 and contender = ced3b27. ced3b27 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants