-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop wasting time in CI on MIRI runs #3610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 300 300
Lines 56314 56314
=======================================
+ Hits 48473 48475 +2
+ Misses 7841 7839 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍 @alamb i will update in ballista apache/datafusion-ballista#283 (comment)
Benchmark runs are scheduled for baseline = c8a9ea0 and contender = ced3b27. ced3b27 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #3045
Rationale for this change
DataFusion runs a check called "MIRI" as part of CI. Example: https://github.com/apache/arrow-datafusion/actions/runs/3119021327/jobs/5058711471
This check always completes successfully as the results of running miri are
|| true
d (aka ignored)This provides a false sense of security (we run MIRI!) as well as wasting CI resources
What changes are included in this PR?
Stop running MIRI check in CI
Are there any user-facing changes?
No
Follow on ticket to create a working MIRI CI check: #3611