Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom window frame logic (support
ROWS
,RANGE
,PRECEDING
andFOLLOWING
for window functions) #3570Custom window frame logic (support
ROWS
,RANGE
,PRECEDING
andFOLLOWING
for window functions) #3570Changes from 5 commits
242560d
63aa393
4da189f
0e4f532
8428865
5b06b99
850cd8b
fa2cd99
88dffd2
c582e01
b1b27d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reading this I can't help but wonder if the same logic could be found using https://doc.rust-lang.org/std/primitive.slice.html#method.binary_search
Though the subtlety of
left
andright
would need some finaglingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this returns an index then it's a binary search instead of bisect?