Tests showing user defined aggregate returning a struct #3425
Conversation
| @@ -108,12 +108,12 @@ pub mod window; | |||
|
|
|||
| pub mod arrow_typeof; | |||
| pub mod decimal; | |||
| mod explain; | |||
| mod idenfifers; | |||
| pub mod explain; | |||
There was a problem hiding this comment.
This is a driveby cleanup to make module definitions in sql/mod.rs consistent
|
|
||
| #[tokio::test] | ||
| /// Basic query for with a udaf returning a structure | ||
| async fn test_udf_returning_struct() { |
There was a problem hiding this comment.
It is actually quite cool that this works 👌
Codecov Report
@@ Coverage Diff @@
## master #3425 +/- ##
==========================================
+ Coverage 85.64% 85.66% +0.02%
==========================================
Files 296 297 +1
Lines 54464 54538 +74
==========================================
+ Hits 46643 46719 +76
+ Misses 7821 7819 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Benchmark runs are scheduled for baseline = 4d22076 and contender = 5af707b. 5af707b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #600
Rationale for this change
It turns out that DataFusion supports user defined aggregates returning a struct but there is very little end to end SQL testing of the feature
Adding end to end testing will ensure that the feature doesn't get broken accidentally any maybe provides an example for others to start from when working on their own features
What changes are included in this PR?
Add a new "rust integration test" showing a user defined aggregate returning a struct. It can be run like
cargo test -p datafusion --test user_defined_aggregatesAre there any user-facing changes?
No