Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Improvements to type coercion rule #3379

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Minor: Improvements to type coercion rule #3379

merged 2 commits into from
Sep 6, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 6, 2022 •
edited
Loading

Draft as it builds on #3222

Which issue does this PR close?

re #3221

Rationale for this change

I saw a few minor improvements while reviewing #3222

What changes are included in this PR?

  1. Improve error message
  2. Avoid a clone
  3. Remove special case interval handling

Are there any user-facing changes?

No

@alamb alamb mentioned this pull request Sep 6, 2022
Merged
@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions labels Sep 6, 2022
alamb
alamb commented Sep 6, 2022
View reviewed changes
datafusion/optimizer/src/type_coercion.rs
Expr::BinaryExpr { left, op, right } => {
let left_type = left.get_type(&self.schema)?;
let right_type = right.get_type(&self.schema)?;
match right_type {
DataType::Interval(_) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the special case pointed out by @liukun4515 as it does not seem to be needed anymore

@alamb alamb marked this pull request as ready for review September 6, 2022 12:17
@github-actions github-actions bot removed logical-expr Logical plan and expressions core Core DataFusion crate labels Sep 6, 2022
andygrove
andygrove approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @alamb

@liukun4515 liukun4515 mentioned this pull request Sep 6, 2022
Merged
@andygrove andygrove merged commit c89b10f into apache:master Sep 6, 2022
@ursabot
Copy link

ursabot commented Sep 6, 2022

Benchmark runs are scheduled for baseline = 08a85db and contender = c89b10f. c89b10f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/cleanups3 branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@liukun4515 liukun4515 Awaiting requested review from liukun4515

Assignees
No one assigned
Labels
optimizer Optimizer rules physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @andygrove