Remove Result.unwrap from single_distinct_to_groupby #3345
Conversation
|
fyi @avantgardnerio |
| == aggr_expr.len() | ||
| && fields_set.len() == 1 | ||
| for expr in args { | ||
| fields_set.insert(expr.name()?); |
There was a problem hiding this comment.
Higher-order functions look good on interview code, but they could use a better story regarding error-propagation :/
|
Benchmark runs are scheduled for baseline = ac5ec3c and contender = e032bc4. e032bc4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3314
Rationale for this change
Optimizer can recover from rules that fail with Err but not if they panic
What changes are included in this PR?
Remove unwrap
Are there any user-facing changes?
No