Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable! from filter push down rule #3342

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Remove unreachable! from filter push down rule #3342

merged 1 commit into from
Sep 2, 2022

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Part of #3314

Rationale for this change

Optimizer can recover from rules that fail with Err but not if they panic

What changes are included in this PR?

Use Err instead of unreachable!

Are there any user-facing changes?

No

@andygrove andygrove changed the title Remove unreachable from filter push down rule Remove unreachable! from filter push down rule Sep 2, 2022
@github-actions github-actions bot added the optimizer Optimizer rules label Sep 2, 2022
@andygrove
Copy link
Member Author

cc @avantgardnerio

avantgardnerio
avantgardnerio approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@andygrove andygrove merged commit a49e01e into apache:master Sep 2, 2022
@andygrove andygrove deleted the remove-unreachable-filter-push-down branch September 2, 2022 21:20
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = 5bdd55b and contender = a49e01e. a49e01e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kmitchener pushed a commit to kmitchener/arrow-datafusion that referenced this pull request Sep 4, 2022
@andygrove @kmitchener
Remove unreachable from filter push down rule (apache#3342)
9ab7377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andygrove @ursabot @avantgardnerio