Re-implement ExprIdentifierVisitor::desc_expr to use Expr::Display #3339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3330
Rationale for this change
Expr
already implements theDisplay
trait so it doesn't seem necessary forExprIdentifierVisitor
to have an alternate way to build descriptions ofExpr
.The
ExprIdentifierVisitor::desc_expr
generated names are hard to interpret as well, IMO, so better to use the full description.For example:
What changes are included in this PR?
ExprIdentifierVisitor
now just delegates toimpl Display for Expr
Are there any user-facing changes?
Plans will look different