Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement ExprIdentifierVisitor::desc_expr to use Expr::Display #3339

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Sep 2, 2022

Which issue does this PR close?

Part of #3330

Rationale for this change

Expr already implements the Display trait so it doesn't seem necessary for ExprIdentifierVisitor to have an alternate way to build descriptions of Expr.

The ExprIdentifierVisitor::desc_expr generated names are hard to interpret as well, IMO, so better to use the full description.

For example:

BEFORE: AggregateFunction-AVGfalseColumn-c
AFTER:  AVG(#c)

What changes are included in this PR?

ExprIdentifierVisitor now just delegates to impl Display for Expr

Are there any user-facing changes?

Plans will look different

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Sep 2, 2022
@andygrove
Copy link
Member Author

@waynexia Does this look reasonable?

@andygrove andygrove force-pushed the ExprIdentifierVisitor-desc-expr branch from bd5ae23 to 81cc956 Compare September 2, 2022 14:30
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up. This Display way looks more pretty, I like it!

@andygrove andygrove merged commit 786c319 into apache:master Sep 3, 2022
@ursabot
Copy link

ursabot commented Sep 3, 2022

Benchmark runs are scheduled for baseline = e26452a and contender = 786c319. 786c319 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kmitchener pushed a commit to kmitchener/arrow-datafusion that referenced this pull request Sep 4, 2022
@andygrove andygrove deleted the ExprIdentifierVisitor-desc-expr branch January 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants