Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: remove test code that's in the arrow library now #3206

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

kmitchener
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Handling of the FixedSizeList datatype is in the arrow array_value_to_string() function, it doesn't need special case handling in DF test code anymore.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Aug 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3206 (928c10b) into master (929eb6d) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 928c10b differs from pull request most recent head 19e16f5. Consider uploading reports for the commit 19e16f5 to get more accurate results

@@           Coverage Diff           @@
##           master    #3206   +/-   ##
=======================================
  Coverage   85.87%   85.88%           
=======================================
  Files         291      291           
  Lines       52885    52879    -6     
=======================================
- Hits        45415    45413    -2     
+ Misses       7470     7466    -4     
Impacted Files Coverage Δ
datafusion/core/tests/sql/mod.rs 97.77% <ø> (+0.82%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 77.60% <0.00%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmitchener !

@alamb alamb merged commit a52dbb0 into apache:master Aug 19, 2022
@ursabot
Copy link

ursabot commented Aug 19, 2022

Benchmark runs are scheduled for baseline = 3c911ff and contender = a52dbb0. a52dbb0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kmitchener kmitchener deleted the minor-test-cleanup branch August 19, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants