-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlparser-0.21] Use released crate #3202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs a rebase -- but I reviewed 8534b0a and it looks good to me 👍
8534b0a
to
932d990
Compare
I took the liberty of rebasing this branch |
Codecov Report
@@ Coverage Diff @@
## sqlparser-0.21 #3202 +/- ##
===============================================
Coverage 85.84% 85.84%
===============================================
Files 291 291
Lines 52898 52905 +7
===============================================
+ Hits 45409 45417 +8
+ Misses 7489 7488 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you @alamb! |
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193) * Update planning for LIKE due to changes in sqlparser (#3194) * rename array function to make_array (#3199) * [sqlparser-0.21] Update trimExpr members during planning (#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (#3202) Co-authored-by: Ayush Dattagupta <[email protected]>
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <[email protected]>
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <[email protected]>
Which issue does this PR close?
Closes #3192
Builds on #3181
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?